Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/738?usp=email )
Change subject: Move to common backend_driver type in struct tuntap ...................................................................... Patch Set 5: Code-Review-1 (3 comments) Patchset: PS5: Generally LGTM. File src/openvpn/tun.h: http://gerrit.openvpn.net/c/openvpn/+/738/comment/053bc957_6ad67db1 : PS5, Line 46: #ifdef WIN32 Do we really need pre-processor here? Doesn't hurt if the enum contains unused values, does it? File src/openvpn/tun.c: http://gerrit.openvpn.net/c/openvpn/+/738/comment/a1b5e9c3_9c9289a1 : PS5, Line 63: #ifdef WIN32 Again, don't think we really need the #ifdefs here... -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/738?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8c0e9f32b235cb262ca2be6aac8d520e49b30d74 Gerrit-Change-Number: 738 Gerrit-PatchSet: 5 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Tue, 17 Sep 2024 11:53:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
