Attention is currently required from: mattock, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/663?usp=email )
Change subject: Add t_server_null test suite ...................................................................... Patch Set 1: Code-Review-2 (2 comments) File tests/t_server_null_client.sh: http://gerrit.openvpn.net/c/openvpn/+/663/comment/923993f1_1319ae66 : PS1, Line 1: #!/usr/bin/env bash bash is not necessarily available on BSD. http://gerrit.openvpn.net/c/openvpn/+/663/comment/54cb0bde_ba12a5e5 : PS1, Line 74: # Wait until servers are up. This check is based on the presence of processes This check does not work correctly. You often see something like this in the output of the test: cat: t_server_null_server-1194_udp.pid: No such file or directory cat: t_server_null_server-1195_tcp.pid: No such file or directory error: list of process IDs must follow -p Usage: ps [options] Try 'ps --help <simple|list|output|threads|misc|all>' or 'ps --help <s|l|o|t|m|a>' for additional help text. For more details see ps(1). OpenVPN test servers up: 0/0 Does not necessarily fail the test but definitely does not do what it is supposed to do. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/663?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1b54da258c7d15551b6c3de7522a0d19afdb66de Gerrit-Change-Number: 663 Gerrit-PatchSet: 1 Gerrit-Owner: mattock <sam...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: mattock <sam...@openvpn.net> Gerrit-Comment-Date: Fri, 07 Jun 2024 11:36:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
