Attention is currently required from: mattock, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/643?usp=email )
Change subject: Add t_server_null test suite ...................................................................... Patch Set 2: (1 comment) File tests/t_server_null_client.sh: http://gerrit.openvpn.net/c/openvpn/+/643/comment/52da0659_0e3d50cb : PS2, Line 74: # Wait until servers are up. This check is based on the presence of processes This code does not seem to work reliably. I often see something like this in the build logs: cat: t_server_null_server-1194_udp.pid: No such file or directory cat: t_server_null_server-1195_tcp.pid: No such file or directory error: list of process IDs must follow -p Usage: ps [options] Try 'ps --help <simple|list|output|threads|misc|all>' or 'ps --help <s|l|o|t|m|a>' for additional help text. For more details see ps(1). OpenVPN test servers up: 0/0 So that means that the servers hadn't created the pid files yet and so the test suceeded? Probably server_count should be based on the amount of defined servers and not server_pids? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/643?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I1b54da258c7d15551b6c3de7522a0d19afdb66de Gerrit-Change-Number: 643 Gerrit-PatchSet: 2 Gerrit-Owner: mattock <samuli.seppa...@gmail.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: mattock <samuli.seppa...@gmail.com> Gerrit-Comment-Date: Wed, 05 Jun 2024 13:51:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
