Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/547?usp=email )
Change subject: Remove openvpn_snprintf and similar functions ...................................................................... Patch Set 2: Code-Review-1 (3 comments) Patchset: PS2: Unfortunately, this fails -Werror msbuild builds now, see comment in interactive.c File src/openvpn/proxy.c: http://gerrit.openvpn.net/c/openvpn/+/547/comment/b37effa6_d450b13a : PS2, Line 962: if (sret >= sizeof(buf)) > if this can truly happen, does it mean that the buffer is undersized compared > to the size of all var […] this code is not part of the actual patchset, but a gerrit artefact due to rebasing. *This* patchset only replaces openvpn_snprintf() with snprintf(). File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/547/comment/918c9772_0150ba41 : PS2, Line 2007: sud.options, svc_pipe); This makes GHA msbuild build fails now, with ``` D:\a\openvpn\openvpn\src\openvpnserv\interactive.c(2006,37): warning C4477: 'swprintf' : format string '%llu' requires an argument of type 'unsigned __int64', but variadic argument 2 has type 'HANDLE' [D:\a\openvpn\openvpn\out\build\win-amd64-release\src\openvpnserv\openvpnserv.vcxproj] ``` so it seems the cast to something-int (`DWORD`?) is needed. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/547?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I07096977e3b562bcb5d2c6f11673a4175b8e12ac Gerrit-Change-Number: 547 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <a...@unstable.cc> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Mon, 08 Apr 2024 08:22:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: ordex <a...@unstable.cc> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
