Attention is currently required from: flichtenheld, plaisthos. ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/547?usp=email )
Change subject: Remove openvpn_snprintf and similar functions ...................................................................... Patch Set 2: Code-Review+2 (4 comments) Patchset: PS2: closing some comments as they were commenting code that did not really change with this patch... The only remaining comment is about a comment in the UT which is a bit cryptic. Maybe that can be adjusted on the fly. Other than that, the code looks good to me <3 File src/openvpn/proxy.c: http://gerrit.openvpn.net/c/openvpn/+/547/comment/f78adfbf_ca231ac7 : PS2, Line 962: if (sret >= sizeof(buf)) > if this can truly happen, does it mean that the buffer is undersized compared > to the size of all var […] Done File src/openvpn/socks.c: http://gerrit.openvpn.net/c/openvpn/+/547/comment/0f6508ea_b21108c0 : PS2, Line 114: (int) strlen(creds.username), creds.username, > normally we don't put a paceb etween the cast and the variable name. […] Done http://gerrit.openvpn.net/c/openvpn/+/547/comment/b4ed3e45_e9af3876 : PS2, Line 116: ASSERT(sret <= sizeof(to_send)); > why ASSERT here while in other cases we just go to error or cleanup? Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/547?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I07096977e3b562bcb5d2c6f11673a4175b8e12ac Gerrit-Change-Number: 547 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <a...@unstable.cc> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Mon, 08 Apr 2024 06:59:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: ordex <a...@unstable.cc> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
