Attention is currently required from: cron2, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/521?usp=email )
Change subject: t_client.sh: Allow to skip tests ...................................................................... Patch Set 4: (3 comments) File tests/t_client.rc-sample: http://gerrit.openvpn.net/c/openvpn/+/521/comment/fe9c7617_bd6d46f5 : PS4, Line 67: # SKIP_x = "commands to execute before openvpn, skip test on failure" > TBH, I do not like `SKIP_x` because it just tells me "well, yes, skip this > test". […] Changed to CHECK_SKIP http://gerrit.openvpn.net/c/openvpn/+/521/comment/70edeb0f_bee08576 : PS4, Line 70: # CLEANUP_x = "commands to execute after the test" > this is a very welcome addition to the last options that I forgot to properly > document. […] Acknowledged File tests/unit_tests/openvpn/mock_msg.c: http://gerrit.openvpn.net/c/openvpn/+/521/comment/aeaf2450_604a1484 : PS2, Line 94: endif > Yes, in this PR it is now used in t_client context, which is not a unit test > context Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/521?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I13ea6752c8d102eabcc579e391828c05d5322899 Gerrit-Change-Number: 521 Gerrit-PatchSet: 4 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <a...@unstable.cc> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Wed, 06 Mar 2024 13:54:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Comment-In-Reply-To: ordex <a...@unstable.cc> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
