Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/521?usp=email )
Change subject: t_client.sh: Allow to skip tests ...................................................................... Patch Set 4: Code-Review-1 (4 comments) Patchset: PS4: Took me longer than expected after v4, but I do have some more wishes... (thanks for bearing with me) File tests/Makefile.am: http://gerrit.openvpn.net/c/openvpn/+/521/comment/aabb9cc6_e1155271 : PS4, Line 45: unit_tests/openvpn/mock_msg.c unit_tests/openvpn/mock_msg.h \ OK, so now I do better understand the -DNO_CMOCKA code in unit_tests/openvpn/mock_msg.c - but I'm none the happier. Unit test code is unit test code, and shouldn't be used by something else (= so when trying to understand code in unit_tests/ I don't really want to consider "oh, wait, this is also used by some other piece of code"). But I can't really can come up with a nice alternative that will not boil down to "just add another copy of `msg()` mocking into ntlm_support.c" (because `crypto_load_provider()` needs it). File tests/t_client.rc-sample: http://gerrit.openvpn.net/c/openvpn/+/521/comment/7c7d3b68_b8417006 : PS4, Line 67: # SKIP_x = "commands to execute before openvpn, skip test on failure" TBH, I do not like `SKIP_x` because it just tells me "well, yes, skip this test". I'd suggest to rename it to something like `SKIP_CONDITIONAL_x` or `PRE_TEST_x` or so which better transports the message "ah, this is a command to run, and depending on the outcome, things will be skipped". http://gerrit.openvpn.net/c/openvpn/+/521/comment/34ed3c96_6462fbf2 : PS4, Line 70: # CLEANUP_x = "commands to execute after the test" this is a very welcome addition to the last options that I forgot to properly document. Thanks ;-) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/521?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I13ea6752c8d102eabcc579e391828c05d5322899 Gerrit-Change-Number: 521 Gerrit-PatchSet: 4 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <a...@unstable.cc> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Comment-Date: Wed, 06 Mar 2024 09:57:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
