Attention is currently required from: flichtenheld, its_Giaan. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/529?usp=email )
Change subject: Persist-key: enable persist-key option by default ...................................................................... Patch Set 2: (4 comments) Patchset: PS2: An entry in Changes.rst is missing. File doc/man-sections/unsupported-options.rst: http://gerrit.openvpn.net/c/openvpn/+/529/comment/eb5579c0_cf2fe0e5 : PS2, Line 47: Removed in OpenVPN 2.7. Keys are now always persisted across restarts. Maybe use "Ignored" since OpenVPN 2.7? File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/529/comment/cab1614e_ebf8f6bc : PS2, Line 3630: random whitespace change File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/529/comment/6f595c78_b2ccf3fe : PS2, Line 6965: "please remove it from your configuration."); I don't think we should/warn or threaten to remove that option. That just makes configuration files incompatible in the future without a good reason to do so. For other options like max-routes, we also just ignore them. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/529?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I57f1c2ed42bd9dfd43577238749a9b7f4c1419ff Gerrit-Change-Number: 529 Gerrit-PatchSet: 2 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: its_Giaan <gianma...@mandelbit.com> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Mon, 04 Mar 2024 16:31:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
