Attention is currently required from: flichtenheld, plaisthos. its_Giaan has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/529?usp=email )
Change subject: Persist-key: enable persist-key option by default ...................................................................... Patch Set 1: (5 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/529/comment/e10934a7_2866e37f : PS1, Line 9: This commit changes the default behavior of the OpenVPN > Nitpick: just use "Change the default behavior". "This commit" is redundant > and clunky. Done File doc/man-sections/signals.rst: http://gerrit.openvpn.net/c/openvpn/+/529/comment/cd5281ba_35c80d22 : PS1, Line 13: remote IP address/port based on ``--persist-tun``, ``--persist-local-ip`` > Trailing whitespace Done File doc/man-sections/unsupported-options.rst: http://gerrit.openvpn.net/c/openvpn/+/529/comment/ffcf9cec_929ec0cd : PS1, Line 47: Removed in OpenVPN 2.7. Corresponding behavior is now always enabled. > "Corresponding behavior" is very vague. […] Done File sample/sample-config-files/server.conf: http://gerrit.openvpn.net/c/openvpn/+/529/comment/4fe0fe2f_2a0c3f24 : PS1, Line 277: # The persist options will try to avoid > Nitpick: "The persist options" not correct anymore, since it is only one > option now 😊 Done File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/529/comment/489e0245_c52b6bdb : PS1, Line 6963: "The corresponding behavior is now always enabled." > Same comment about "corresponding behavior" Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/529?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I57f1c2ed42bd9dfd43577238749a9b7f4c1419ff Gerrit-Change-Number: 529 Gerrit-PatchSet: 1 Gerrit-Owner: its_Giaan <gianma...@mandelbit.com> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 20 Feb 2024 14:10:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
