Acked-by: Gert Doering <g...@greenie.muc.de>

This is, amazingly, quite straightforward.  I assumed major complications
but our magic "ask for username and password" function *already* supports
inline, we just didn't use it for --aup yet...

I have stared at the code for a bit (looks good, though the multi-line
calls to get_user_pass_cr() could use some "folding up" now), and
tested with inline

 <auth-user-pass>
 username
 pass
 </auth-user-pass>

and also classic --auth-user-pass with/without filename combinations
(and, me twisted mind, multiple --auth-user-pass statements in the 
same invocation - "last one wins").

Works :-)


Your patch has been applied to the master branch.

commit 7d48d31b8226d5e3a5638e2369876381038bf5e2
Author: Antonio Quartulli
Date:   Sat Sep 17 15:48:32 2022 +0200

     auth-user-pass: add support for inline credentials

     Signed-off-by: Antonio Quartulli <a...@unstable.cc>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20220917134832.16359-...@unstable.cc>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25236.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to