Hi,

On 17/09/2022 14:37, Gert Doering wrote:
Hi,

On Wed, Sep 14, 2022 at 08:59:36PM +0200, Antonio Quartulli wrote:
  #ifdef ENABLE_MANAGEMENT
-        auth_user_pass_setup(c->options.auth_user_pass_file, 
&c->options.sc_info);
+        auth_user_pass_setup(c->options.auth_user_pass_file,
+                             c->options.auth_user_pass_file,
+                             &c->options.sc_info);
  #else
-        auth_user_pass_setup(c->options.auth_user_pass_file, NULL);
+        auth_user_pass_setup(c->options.auth_user_pass_file,
+                             c->options.auth_user_pass_file, NULL);
  #endif

This does not look like it would work...  the second "..._pass_file"
arguments wants to be "..._inline", no?

ehm, right!

Cheers,



@@ -2165,9 +2174,12 @@ key_method_2_write(struct buffer *buf, struct tls_multi 
*multi, struct tls_sessi
      if (auth_user_pass_enabled || (auth_token.token_defined && 
auth_token.defined))
      {
  #ifdef ENABLE_MANAGEMENT
-        auth_user_pass_setup(session->opt->auth_user_pass_file, 
session->opt->sci);
+        auth_user_pass_setup(session->opt->auth_user_pass_file,
+                             session->opt->auth_user_pass_file_inline,
+                             session->opt->sci);
  #else
-        auth_user_pass_setup(session->opt->auth_user_pass_file, NULL);
+        auth_user_pass_setup(session->opt->auth_user_pass_file,
+                             session->opt->auth_user_pass_file_inline, NULL);
  #endif

This one is better :-)

This aside, the change is surprisingly simple.  Seems proxy-user-pass did
the grunt work for us...

gert

--
Antonio Quartulli


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to