Hi,
On 14/09/2022 16:41, Lev Stipakov wrote:
Hi,
One general question about the patch: Whenever we have
defined(TARGET_LINUX) || defined(TARGET_FREEBSD) || defined(_WIN32)
in the DCO code, couldn't we just remove it completely?
Since this is bascially "every time" anyway, isn't it?
Well, almost. There is also Mac and some other platforms which do not have DCO.
but we could still use "ifdef ENABLE_DCO" instead of the OR of those 3, no?
Cheers,
We could likely get rid of those defines if we add disable_dco into
platform-specific tuntap_options
structures. Would it be better to have disable_dco member, assuming
platform doesn't support dco?
--
Antonio Quartulli
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
