On Mon, Sep 12, 2022 at 12:10:57PM +0300, Lev Stipakov wrote: > From: Lev Stipakov <l...@openvpn.net> > > On startup, check following conditions: > > - ovpn-dco-win driver is installed. Perform this check > by trying to open adapter by symbolic name. > > - options are compatible with dco. Same checks as on > Linux and FreeBSD. In addition, check that --mode server > is not used and --windows-driver is not set to tap-windows6/wintun. > > If both checks are passed, use DCO. > > Move options_postprocess_mutate_invariant() call > below since it depends on selected windows driver. > > dco_check_option() has side effect on Windows - > if dco is not used, it might complain "cipher chachapoly > not supported by dco, disabling dco" if chachapoly > support is missing system-wide. To not to see this, > check dco options only if dco is enabled. This means > moving dco_enabled() from dco_check_startup_option() > to one level above. We do similar thing in > multi_connection_established() before checking ccd options. >
One general question about the patch: Whenever we have defined(TARGET_LINUX) || defined(TARGET_FREEBSD) || defined(_WIN32) in the DCO code, couldn't we just remove it completely? Since this is bascially "every time" anyway, isn't it? Regards, -- Frank Lichtenheld _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
