Hi, On Sat, Aug 20, 2022 at 11:29:55AM +0200, Gert Doering wrote: > Acked-by: Gert Doering <g...@greenie.muc.de> > > I have *not* tested this, but we've discussed the patch on IRC, and the > code matches what we want to achieve. We've had GetProcAddress() dynamic > resolution in the code before (some IPv6 vs XP/Vista stuff, IIRC) and > this all looks reasonable. GHA claims it compiles, and Lev said he has > tested on Win7+Win10. > > (The intention is "have one single openvpn.exe binary for Win7 + Win10/11, > which will do non-dco stuff on Win7 - no driver - and DCO stuff on > Win10/11" - much simpler than having to build extra Win7 installers, and > we still want to support Win7 "unless it's getting too costly") > > Your patch has been applied to the master branch. > > commit 2f8053f9a97584b759d11d05a668d38653508617 > Author: Lev Stipakov > Date: Sat Aug 20 11:47:19 2022 +0300
For the sake of transparency, I did a mispush of this commit to
github+gitlab, with the wrong URL: in the commit message (it was intended
to go to my github instance only). I fixed this about 3 minutes later
for github, but it took a bit for gitlab.
So, if anyone noticed this commit with the ID 532c006b being in the
repo for a few minutes, this was not a malicious person, just fat fingers.
*No code change* between these revisions, just commit message.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
