Acked-by: Gert Doering <g...@greenie.muc.de>
I have *not* tested this, but we've discussed the patch on IRC, and the
code matches what we want to achieve. We've had GetProcAddress() dynamic
resolution in the code before (some IPv6 vs XP/Vista stuff, IIRC) and
this all looks reasonable. GHA claims it compiles, and Lev said he has
tested on Win7+Win10.
(The intention is "have one single openvpn.exe binary for Win7 + Win10/11,
which will do non-dco stuff on Win7 - no driver - and DCO stuff on
Win10/11" - much simpler than having to build extra Win7 installers, and
we still want to support Win7 "unless it's getting too costly")
Your patch has been applied to the master branch.
commit 2f8053f9a97584b759d11d05a668d38653508617
Author: Lev Stipakov
Date: Sat Aug 20 11:47:19 2022 +0300
dco-win: use run-time dynamic linking for GetOverlappedResultEx
Signed-off-by: Lev Stipakov <l...@openvpn.net>
Acked-by: Gert Doering <g...@greenie.muc.de>
Message-Id: <20220820084719.243-1-lstipa...@gmail.com>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25038.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
