Hi,
On Fri, Aug 05, 2022 at 05:13:25PM +0200, Antonio Quartulli wrote:
> #if defined(USE_COMP)
> - if (o->comp.alg != COMP_ALG_UNDEF)
> + if (o->comp.alg != COMP_ALG_UNDEF
> + || o->comp.flags & COMP_F_ALLOW_ASYM
> + || o->comp.flags & COMP_F_ALLOW_COMPRESS)
> {
> - msg(msglevel, "Note: Using compression disables data channel
> offload.");
> + msg(msglevel, "Note: Allowing or using compression disables data
> channel offload.");
It does have an ACK, and it does what it promises to, but I do not
like the message - as in, it's technically correct, but it could be a
bit more helpful in regards to "what does the user need to do now?"
What about
> + msg(msglevel, "Note: '--allow-compression' is not set to 'no'.
> Disabling data channel offload.");
so they know "ah, need to look for that option" (and either set it to "no"
or remove it from the config).
Yes, this is not mentioning "using compression" at all anymore, but this
is indirectly handled - if you have "--allow-compression no", it will
disallow use of "--compress <whatever>" on its own, so we do not need
to mention it in the DCO specific part.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany [email protected]
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
