Hi, On 11/08/2021 14:52, Gert Doering wrote: > Hi, > > On Wed, Aug 11, 2021 at 09:29:22AM +0200, Antonio Quartulli wrote: >> Wouldn't it be better to have one patch of reach default behaviour being >> charged with a concise but focused explanation as to why that default is >> being changed? >> >> After those patches, then another patch could come in implementing >> compat-mode. > > NAK to the proposed approach, because that would give us incompatible > (and unfixable-incompatible) versions in between.
True - your objection makes sense. > > I am open to splitting this patch, but would turn it around > > - compat-mode comes *first*, with an option that basically "does nothing" > > - each change to a default setting brings in the required compat-mode > adjustments > > but I can live with "all in a single commit", provided the commit message > (+ Changes.rst) is clear enough on the "what and why". If the documentation coming with the patch (especially the commit message) is clear enough, then one patch is good for me as well. Ideally we really want to be able to read "this changed from X to Y, because bla bla bla". Just as if we have to read this in 2 years from now and want to know why we did that. Regards, -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
