Hi,

On Wed, Aug 11, 2021 at 09:29:22AM +0200, Antonio Quartulli wrote:
> Wouldn't it be better to have one patch of reach default behaviour being
> charged with a concise but focused explanation as to why that default is
> being changed?
> 
> After those patches, then another patch could come in implementing
> compat-mode.

NAK to the proposed approach, because that would give us incompatible
(and unfixable-incompatible) versions in between.

I am open to splitting this patch, but would turn it around

 - compat-mode comes *first*, with an option that basically "does nothing"

 - each change to a default setting brings in the required compat-mode
   adjustments

but I can live with "all in a single commit", provided the commit message
(+ Changes.rst) is clear enough on the "what and why".

gert

-- 
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             g...@greenie.muc.de

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to