Have not tested anything, just looked a bit at the changes. ACK from Lev is good enough :-) - and getting rid of #ifdef is even better.
Your patch has been applied to the master branch. commit 455d0997931f968ed8c42812106c44941c4ca69b Author: Selva Nair Date: Fri May 21 23:32:30 2021 -0400 Make it explicit that WIndows build requires UNICODE support Signed-off-by: Selva Nair <selva.n...@gmail.com> Acked-by: Lev Stipakov <lstipa...@gmail.com> Message-Id: <20210522033232.20548-1-selva.n...@gmail.com> URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg22437.html Signed-off-by: Gert Doering <g...@greenie.muc.de> -- kind regards, Gert Doering _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel