Hi,

When _DEBUG is defined openvpnmsica builds okay using MSVC, but fails
on mingw (before and after this patch) with errors like

openvpnmsica.c:410:17: error: ‘L__FUNCTION__’ undeclared (first use in
this function); did you mean ‘NLS_FUNCTION’?
     debug_popup(TEXT(__FUNCTION__));

I have left it to be handled by a separate patch.

On gcc (and mingw) __FUNCTION__ == function-name is not a macro and
TEXT(__FUCNTION__) that expands to L__FUNCTION__ is undefined.

We do not really need to convert __FUNCTION__ to wide string for debug
printing so I suggest to fix this by using it as is with %hs as the
print spec for both UNICODE and ANSI builds. No TEXT() required.

If that's okay I'll submit a patch.

The alternative is to use __FUNCTIONW__ when UNICODE is defined, but
it will complicate the logic for no reason.

We have no plans of using σ , µ and ℵₒ in function names any time soon, do we :)

Selva


_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to