Hi, On 08/04/2021 16:02, Arne Schwabe wrote: > NCP has proven to be stable and apart from the one VPN Provider doing > hacky things with homebrewed NCP we have not had any reports about > ncp-disable being required. Remove ncp-disable to simplify code paths. > > Note: This patch breaks client without --pull. The follow up patch > for P2P NCP will restore that. But to avoid all the NCP/non-NCP special > cases to be implemented in P2P. P2P will directly switch from always > non-NCP to always NCP. > > Signed-off-by: Arne Schwabe <a...@rfc2549.org>
The patch looks good to me and passes my basic connectivity tests. Also I got no compile-time complain from any platform I could build on. However, there is a comment that still talk about NCP being disabled/enabled. I think it should be changed too as we don't have the two cases anymore (the if-condition below is modified by this patch): src/openvpn/init.c:2726: * as NCP-fallback or when NCP has been disabled or explicitly Cheers, -- Antonio Quartulli _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
