Am 08.04.21 um 16:36 schrieb Jan Just Keijser: > Hi, > > On 08/04/21 16:02, Arne Schwabe wrote: >> NCP has proven to be stable and apart from the one VPN Provider doing >> hacky things with homebrewed NCP we have not had any reports about >> ncp-disable being required. Remove ncp-disable to simplify code paths. >> >> Note: This patch breaks client without --pull. The follow up patch >> for P2P NCP will restore that. But to avoid all the NCP/non-NCP special >> cases to be implemented in P2P. P2P will directly switch from always >> non-NCP to always NCP. > I would Feature-NAK this : disabling NCP is a valuable option. IMHO.
I disagree here. NCP in 2.5 is mature mature enough that disabling NCP is not necessary any more. If you have any evidence otherwise, please explain a bit more since I personally don't see the value in it. > Also, is the MTU calculation part on the server side now done > correctly? I remember that with 2.4 the server would subtract (or > add, depending on point of iew) far too many bytes to handle NCP Not fully yet but the case where NCP cipher == original cipher has a workaround. Arne _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
