Acked-by: Lev Stipakov <[email protected]>
Lev ACKed the v1 of this patch, with the request to remove the
ASSERT() wrapping - v2 fixes this instead so it actually works, so
that should take the comment into account. I think the ASSERT()
is slightly overdoing things - this cannot fail, and having too
much "did it really not fail?" wrapping makes the code harder to
read again. But then, I did not write the code, and it works...
Not really tested except for "test compile on current OSX and run
make check"
Your patch has been applied to the master branch.
commit 4edcf5710d043d366d8fd52a53b259399678309a
Author: Arne Schwabe
Date: Mon Aug 10 16:37:04 2020 +0200
Skip existing interfaces on opening the first available utun on macOS
Signed-off-by: Arne Schwabe <[email protected]>
Acked-by: Lev Stipakov <[email protected]>
Message-Id: <[email protected]>
URL:
https://www.mail-archive.com/[email protected]/msg20665.html
Signed-off-by: Gert Doering <[email protected]>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
