Your patch has been applied to the master branch.
After some discussion on IRC, Antonio and I have come to the conclusion
that the original code was related to the pre-2.2 threading attempts, and
that "copying 'now' to a new local variable" might have been necessary to
avoid another thread messing with it while comparisons are being made - so
having a thread-local "local_now" is reasonable.
Now, the threading stuff was never finished and removed in 7aa6c12a4424d
nearly 10 years ago... out with it :-)
commit ca514800ca126b69dbde846db819d8bf4c490e68
Author: Arne Schwabe
Date: Thu Jul 9 12:16:03 2020 +0200
Code cleanup: remove superflous variable
Signed-off-by: Arne Schwabe <a...@rfc2549.org>
Acked-by: Antonio Quartulli <anto...@openvpn.net>
Message-Id: <20200709101603.11941-8-a...@rfc2549.org>
URL:
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg20252.html
Signed-off-by: Gert Doering <g...@greenie.muc.de>
--
kind regards,
Gert Doering
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
