Hi, On Thu, Jul 09, 2020 at 12:15:59PM +0200, Arne Schwabe wrote: > This clean ups the code and removes the surprising side effects > of preparing a push reply to also select protocol options. > > We also remember if we have seen a push request without async > push. This improves reaction time if deferred auth is involved > like managment interface deferred auth. The other benefit is > removing a number of ifdefs. > > Signed-off-by: Arne Schwabe <a...@rfc2549.org>
I have tested this on the server side test torture program, and it
reproduceably fails async-auth (with NCP, if that is relevant)
Jul 9 20:24:55 gentoo tun-udp-p2mp-global-authpam[9557]:
cron2-freebsd-tc-amd64/2001:608:0:814::f000:21 Key
[AF_INET6]2001:608:0:814::f000:21:28650 [0] not initialized (yet), dropping
packet.
All other tests succeed.
Applying 5/8 on top of this makes the async auth test succeed again
(and normal connections as well, from a quick glance - the full test
is still running).
Let's discuss tomorrow how to proceed here.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
