On Mon, 2020-06-22 at 19:28 +0200, Gert Doering wrote: > Hi, > > On Mon, Jun 22, 2020 at 10:06:44AM -0700, James Bottomley wrote: > > > [..] > > > > Right, that's what the patch in the url does: uses .so on both > > > > mac > > > > and linux. > > > > > > I got all confused with your "v6" patch and your "v7" patch, > > > which > > > did other things, and but did not have a "v6" in the history :-) > > > > > > *This* patch definitely looks like it's doing the right thing on > > > MacOS. > > > > Great, thanks ... I'll rewrap it and submit as a separate patch > > email > > with cover letter. > > I was about to just merge what I have, but it exploded on me on > FreeBSD > now - and I can't really figure out why (yet)... > > libtool: link: (cd ".libs" && rm -f "libtestengine.so.0" && ln -s > "libtestengine.so.0.0.0" "libtestengine.so.0") > libtool: link: (cd ".libs" && rm -f "libtestengine.so" && ln -s > "libtestengine.so.0.0.0" "libtestengine.so") > libtool: link: ar cru .libs/libtestengine.a libtestengine_la- > libtestengine.o > libtool: link: ranlib .libs/libtestengine.a > libtool: link: ( cd ".libs" && rm -f "libtestengine.la" && ln -s > "../libtestengine.la" "libtestengine.la" ) > make check-TESTS > make[5]: don't know how to make openssl.cnf. Stop > > make[5]: stopped in /home/gert/src/openvpn-maint/test-build-master- > fbsd/tests/unit_tests/engine-key > > > it seems as if there is an implicit rule "somewhere" that Linux make > has > and FreeBSD make not how to build openssl.cnf from > $(srcdir)/openssl.cnf.in > - on Linux, when I remove "openssl.cnf" from the target dir and re- > run > "make check", I get > > make[5]: Entering directory '/rhome/gert/src/openvpn-maint/test- > build-master-ossl111/tests/unit_tests/engine-key' > sed "s|ABSBUILDDIR|/rhome/gert/src/openvpn-maint/test-build-master- > ossl111/tests/unit_tests/engine-key|" < > ../../../../openvpn/tests/unit_tests/engine-key/openssl.cnf.in > > openssl.cnf > PASS: check_engine_keys.sh > > > Ah. If I run "gmake check", it also passes on FreeBSD... > > gmake[5]: Entering directory '/home/gert/src/openvpn-maint/test- > build-master-fbsd/tests/unit_tests/engine-key' > sed "s|ABSBUILDDIR|/home/gert/src/openvpn-maint/test-build-master- > fbsd/tests/unit_tests/engine-key|" < > ../../../../openvpn/tests/unit_tests/engine-key/openssl.cnf.in > > openssl.cnf > PASS: check_engine_keys.sh > ============= > 1 test passed > ============= > > ... so the engine part *itself* is fine, just the "openssl.cnf from > .in" doesn't work with BSD make... > > > We need a v7 (or v8?) :-(
That will be my fault. I assumed automake always ran with gnu make, so
the .cnf rule is in gnu make syntax at the bottom of (Makefile.am):
$(builddir)/%.cnf: $(srcdir)/%.cnf.in
sed "s|ABSBUILDDIR|$(abs_builddir)|" < $< > $@
If I just spell everything out and don't use the percent wildcard, it
should work even on legacy make.
James
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
