Am 06.06.20 um 17:22 schrieb James Bottomley:
> On Sat, 2020-06-06 at 13:28 +0200, Gert Doering wrote:
>> Hi,
>>
>> On Sat, Jun 06, 2020 at 12:43:10PM +0200, Arne Schwabe wrote:
>>>> Naive question - can we not just use a .so on Mac?  Like,
>>>> consistent, build .so, request .so from openssl.cnf?
>>>
>>> I thought I tested that and it didn't work but I tested it again
>>> and that also works.
>>
>> Then let's just do that, and simplifiy the test stuff :-)
>>
>> (Building a "production quality" OpenSSL engine would need to do what
>> the platform wants, but for "this is really just to test the OpenVPN
>> code", I think "less autoconf hoops is better")
> 
> Well, I am intellectually curious since I maintain the TPM engine for
> openssl.  But Macs don't have TPMs so no-one is ever going to complain
> ...
> 
> The only remaining problem is the lack of environment variable support
> in MAC openssl which I'll fix by using the absolute path.  If it works
> I think below is the replacement patch.
> 

Looks more like one step forward, two back:
openssl.cnf absolute path looks good:

dynamic_path    =
/Users/arne/oss/openvpn-ossl/tests/unit_tests/engine-key/.libs/libtestengine.so

But now it has .so there. Alos the .libs directory now has neither .so
nor .dylib


engine-key% find .
.
./libtestengine_la-libtestengine.o
./Makefile
./libtestengine.la
./libtestengine_la-libtestengine.lo
./openssl.cnf
./log.txt
./.deps
./.deps/libtestengine_la-libtestengine.Plo
./.libs
./.libs/libtestengine_la-libtestengine.o
./.libs/libtestengine.la
./.libs/libtestengine.a
./passwd
./client.key


(This is an out of tree build so only generated files here)

Make log:

make check
[...]
Making check in engine-key
Makefile:451: .deps/libtestengine_la-libtestengine.Plo: No such file or
directory
/Applications/Xcode.app/Contents/Developer/usr/bin/make  libtestengine.la
/bin/sh ../../../libtool  --tag=CC   --mode=compile clang
-DHAVE_CONFIG_H -I.
-I../../../../openvpn-git/tests/unit_tests/engine-key -I../../..
-I../../../include    -I/usr/local/opt/openssl@1.1/include
-I../../../../openvpn-git/include
-I/usr/local/Cellar/cmocka/1.1.5/include -I -I -Wall
-Wno-unused-parameter -Wno-unused-function -O2 -g -Wall -std=c99 -MT
libtestengine_la-libtestengine.lo -MD -MP -MF
.deps/libtestengine_la-libtestengine.Tpo -c -o
libtestengine_la-libtestengine.lo `test -f 'libtestengine.c' || echo
'../../../../openvpn-git/tests/unit_tests/engine-key/'`libtestengine.c
libtool: compile:  clang -DHAVE_CONFIG_H -I.
-I../../../../openvpn-git/tests/unit_tests/engine-key -I../../..
-I../../../include -I/usr/local/opt/openssl@1.1/include
-I../../../../openvpn-git/include
-I/usr/local/Cellar/cmocka/1.1.5/include -I -I -Wall
-Wno-unused-parameter -Wno-unused-function -O2 -g -Wall -std=c99 -MT
libtestengine_la-libtestengine.lo -MD -MP -MF
.deps/libtestengine_la-libtestengine.Tpo -c
../../../../openvpn-git/tests/unit_tests/engine-key/libtestengine.c
-fno-common -DPIC -o .libs/libtestengine_la-libtestengine.o
libtool: compile:  clang -DHAVE_CONFIG_H -I.
-I../../../../openvpn-git/tests/unit_tests/engine-key -I../../..
-I../../../include -I/usr/local/opt/openssl@1.1/include
-I../../../../openvpn-git/include
-I/usr/local/Cellar/cmocka/1.1.5/include -I -I -Wall
-Wno-unused-parameter -Wno-unused-function -O2 -g -Wall -std=c99 -MT
libtestengine_la-libtestengine.lo -MD -MP -MF
.deps/libtestengine_la-libtestengine.Tpo -c
../../../../openvpn-git/tests/unit_tests/engine-key/libtestengine.c -o
libtestengine_la-libtestengine.o >/dev/null 2>&1
mv -f .deps/libtestengine_la-libtestengine.Tpo
.deps/libtestengine_la-libtestengine.Plo
/bin/sh ../../../libtool  --tag=CC   --mode=link clang
-I/usr/local/opt/openssl@1.1/include   -I../../../../openvpn-git/include
-I/usr/local/Cellar/cmocka/1.1.5/include -I -I -Wall
-Wno-unused-parameter -Wno-unused-function -O2 -g -Wall -std=c99
-L/usr/local/opt/openssl@1.1/lib -lcrypto -lssl
-L/usr/local/Cellar/cmocka/1.1.5/lib -lcmocka -avoid-version -module
-shared -export-dynamic  -o libtestengine.la
libtestengine_la-libtestengine.lo  -lresolv
libtool: link: ar cru .libs/libtestengine.a
.libs/libtestengine_la-libtestengine.o
libtool: link: ranlib .libs/libtestengine.a
libtool: link: ( cd ".libs" && rm -f "libtestengine.la" && ln -s
"../libtestengine.la" "libtestengine.la" )
/Applications/Xcode.app/Contents/Developer/usr/bin/make  check-TESTS
sed
"s|SHREXT|.so|;s|ABSBUILDDIR|/Users/arne/oss/openvpn-ossl/tests/unit_tests/engine-key|"
< ../../../../openvpn-git/tests/unit_tests/engine-key/openssl.cnf.in >
openssl.cnf

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to