Am 14.11.19 um 22:58 schrieb Selva Nair: > Hi David > > Thanks for the comments > > My idea was just to add -Werror right in the line above, and not > extend the > ACL_CHECK_ADD_COMPILE_FLAGS macro with another argument. > > > I'm fine with that approach as well. Let me know if you want a v2. > > > I think you said it pretty well in your mail: > > > Darn compilers and darn -Werror > > > So your change does improve Clang ... I dunno what we will do with GCC. > > > It doesn't affect gcc as gcc does error (or ignore -- see below) > unsupported options with or without -Werror. So I think we are okay. > travis build on my fork confirms that: > https://travis-ci.org/selvanair/openvpn/builds/612019849 > > However, gcc does have quirky behaviour when it comes to options like > -Wno-xx-yy. It just accepts them silently[*] with or without -Werror. > That works fine for us, but it does generate an error about that > unsupported option if any other error is encountered during the build. > As other errors are anyway a show-stopper, I think we can live with that. > > Selva > > [*] I think their reasoning is that -Wno-xx-yy can be thus used to > suppress warnings added to newer versions without breaking builds with > older ones. But clang doesn't share that view.
I agree with Selva here. If we cannot get rid of the warnings themselves this seems to be the only sane way. So I am not totally with this stuff but it is better than the altneratives at the moment. And I really annoyed by all these new warnings of Clang Acked-By: Arne Schwabe <a...@rfc2549.org> Arne
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
