Forgot to hit send on this, and probably this is only partially relevant now, but here goes.
Hi On Sun, Nov 10, 2019 at 12:03 PM Gert Doering <g...@greenie.muc.de> wrote: > Hi, > > On Sun, Nov 10, 2019 at 11:48:16AM -0500, Selva Nair wrote: > > But it seems it may also affect mingw builds on travis. I would resist > the > > temptation to add -Werror in general and to Windows cross-build in > > particular. > > Yeah, we're not intending to. > But the patch does affect cross-compilation for Windows on linux. Unless restricted to a very small cross-section (say gcc x.y + linux) this is going to cause a lot of grief. Note that every check run by configure that succeeds with warnings will become mysterious error at build time. There may be other unexpected failures too. -Werror is never fit for production in my view. There is a reason why warnings are warnings. Just my 2c. Selva
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
