Hi,
On Sun, Nov 10, 2019 at 8:36 AM Antonio Quartulli <a...@unstable.cc> wrote:
> Signed-off-by: Antonio Quartulli <a...@unstable.cc>
> ---
> .travis/build-check.sh | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.travis/build-check.sh b/.travis/build-check.sh
> index 039a7dcf..250bb454 100755
> --- a/.travis/build-check.sh
> +++ b/.travis/build-check.sh
> @@ -8,6 +8,7 @@ fi
>
> if [ "${TRAVIS_OS_NAME}" = "linux" ]; then
> export LD_LIBRARY_PATH="${PREFIX}/lib:${LD_LIBRARY_PATH:-}"
> + export CFLAGS="${CFLAGS} -Werror"
> fi
>
If this is only for linux (and travis), and works with the current code
base, probably its fine.
But it seems it may also affect mingw builds on travis. I would resist the
temptation to add -Werror in general and to Windows cross-build in
particular.
Not all warnings can be fixed easily. Often the only option is to hide the
warning (e.g, by adding a cast) which imo is not always a good strategy.
-Werror just forces one's hand to use tricks that hide warnings.
Selva
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
