Hi, > This is painful to read, and I bet it was even more painful to write. I > am sorry it came to this, though it does look like it should(TM) work.
I don't blame Microsoft for this mess. Version lies actually solve a lot of problems with legacy software. > From what I gather, the OS version should be checked in the > CustomAction's MSI execution conditions instead of in the CustomAction > itself. The appropriate information can then be passed in based on that: > > https://blogs.msdn.microsoft.com/cjacks/2009/05/06/why-custom-actions- > get-a-windows-vista-version-lie-on-windows-7/ The post on this link is true for Windows 7 (May 6, 2009). It's 2018 now and MSI's property VersionNT got stuck on Windows 8 (602 if I recall correctly). Even when run on Windows 10. Each time Microsoft ceils the version mechanism, they should have introduced a new one: e.g. Version9X >> VersionNT >> Version81. This would keep the legacy MSI packages that are using VersionNT think they're on Windows 8, and allow the new packages to test for Windows 10 in a clean way. It would have been a lot easier to just have an MSI condition (e.g. install WHQL flavour of driver if Version81 AND Version81>=1000 AND MsiNTProductType>=2). I am open to suggestions, how to make a "regular/attestation signed/WHQL" selection logic in the MSI. MSI packages have up to three driver flavours packed and only one must be installed: - x86 MSI has regular+attestation signed - x64 has regular+attestation+WHQL - ARM64 will have attestation signed only > It might be somewhat more convenient to add the PID to the debug > MessageBox call, but it is probably MUCH more convenient to use the > CustomAction debugging facility built into the MSI service itself: > > https://docs.microsoft.com/en-us/windows/desktop/Msi/debugging-custom- > actions Many thanks for this. I will test the MsiBreak method shortly and remove the MessageBox calls completely for a cleaner code then. Regards, Simon
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
