Hi, see below:
On 08/10/18 06:30, Steffan Karger wrote:
[CUT]
> diff --git a/src/openvpn/crypto_mbedtls.c b/src/openvpn/crypto_mbedtls.c
> index 0c39eccc..54ac1893 100644
> --- a/src/openvpn/crypto_mbedtls.c
> +++ b/src/openvpn/crypto_mbedtls.c
> @@ -140,26 +140,6 @@ const cipher_name_pair cipher_name_translation_table[] =
> {
> const size_t cipher_name_translation_table_count =
> sizeof(cipher_name_translation_table) /
> sizeof(*cipher_name_translation_table);
>
> -static void
> -print_cipher(const cipher_kt_t *info)
> -{
> - if (info && (cipher_kt_mode_cbc(info)
> -#ifdef HAVE_AEAD_CIPHER_MODES
> - || cipher_kt_mode_aead(info)
> -#endif
> - ))
> - {
> - const char *ssl_only = cipher_kt_mode_cbc(info) ?
> - "" : ", TLS client/server mode only";
> - const char *var_key_size = info->flags &
> MBEDTLS_CIPHER_VARIABLE_KEY_LEN ?
> - " by default" : "";
> -
> - printf("%s (%d bit key%s, %d bit block%s)\n",
> - cipher_kt_name(info), cipher_kt_key_size(info) * 8,
> var_key_size,
> - cipher_kt_block_size(info) * 8, ssl_only);
> - }
> -}
> -
> void
> show_available_ciphers(void)
> {
> @@ -175,7 +155,8 @@ show_available_ciphers(void)
> while (*ciphers != 0)
> {
> const cipher_kt_t *info = mbedtls_cipher_info_from_type(*ciphers);
> - if (info && !cipher_kt_insecure(info))
> + if (info && !cipher_kt_insecure(info)
> + && (cipher_kt_mode_aead(info) || cipher_kt_mode_cbc(info)))
> {
> print_cipher(info);
apparently crypto.h is not included:
crypto_mbedtls.c: In function ‘show_available_ciphers’:
crypto_mbedtls.c:161:13: warning: implicit declaration of function
‘print_cipher’; did you mean ‘print_argv’? [-Wimplicit-function-declaration]
print_cipher(info);
^~~~~~~~~~~~
When compiling with OpenSSL I couldn't see any warning.
Cheers,
--
Antonio Quartulli
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
