Hi, On 07/10/18 21:28, Antonio Quartulli wrote: >> +#if defined(MBEDTLS_CHACHAPOLY_C) && (MBEDTLS_VERSION_NUMBER >= 0x020C0000) > > Why do we need the dual condition? Isn't MBEDTLS_CHACHAPOLY_C enough to > know mbedTLS has what we need? Or you feel like we have to demand a > specific mbedTLS version when using ChaCha20?
Just to reinforce my argument: ChaCha20-Poly1305 was introduced with ce66d5e8e (in mbedTLS upstream) and a quick search shows: mbedtls $ git tag --contains ce66d5e8e mbedtls-2.12.0 mbedtls-2.13.0 mbedtls-2.13.1 Given that 2.12 is 0x020C0000, I am fairly sure there is no reason to have both conditions in the if guard. But I might still be missing something. (p.s. I am arguing simply because I want to avoid more version-based ifdef that may become new nightmares) Cheers, -- Antonio Quartulli
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
