On Mon, Jun 18, 2018 at 2:40 PM, Gert Doering <g...@greenie.muc.de> wrote: > > Hi, > > On Wed, Jun 13, 2018 at 10:12:13PM +0800, Antonio Quartulli wrote: > > From: Antonio Quartulli <anto...@openvpn.net> > > > > This patch ensures that the TAP driver on a windows host is still > > configured, even though no IPv4 has been provided. > > > > In this case the TAP driver ioctl will be invoked with a fake > > 0.0.0.0/0.0.0.0 IPv4 which will simply start the interface and > > get it to a working state. > > > > Trac: #208 > > Signed-off-by: Antonio Quartulli <anto...@openvpn.net> > > I think this is good enough, though I haven't tested it yet (compile > and run). Will do that tomorrow, before I merge & push. > > Before I go ahead with it - Selva, are you fine with this version?
I believe this is the same as the gitlab version I had tested and commented on. I only had some opinionated remarks (nothing critical), so this should be good to merge. Selva ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
