Hi, On Wed, Jun 06, 2018 at 12:11:40AM +0800, Antonio Quartulli wrote: > > Without having done much review here, just one initial caveat: did you > > test this with --ifconfig-pool-persist? What happens? > > It should just be ignored. > At the moment pool-persist works only for IPv4 and there is no support > for IPv6. This has not been changed by this patchset.
Well, it does save the (calculated) v6 address into the save file...
So, what happens if you run a server with --ifconfig-pool-persist and
no IPv4? Will it crash, not write anything to the file, write garbage?
> I added a check about it in ifconfig_pool_read():
>
> 521 /* IPv6 logic not implemented yet, therefore bail out if no IPv4
> pool was
> 522 * configured
> 523 */
> 524 if (pool && !pool->ipv4.enabled)
> 525 {
> 526 return;
> 527 }
We should aim to make this work as well (but it could be patch 6 of the
series :-)).
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
