Hi, On Tue, Jun 5, 2018 at 12:22 PM, Antonio Quartulli <a...@unstable.cc> wrote: > Hi, > > On 05/06/18 23:54, Selva Nair wrote: > [cut] >>> ACK on the feature, but NAK on "we can do this more nicely" reasons :-) >>> >>> First, I'd leave off the bits about "this can be useful" of the commit >>> message - because that's not the point of this patch, you can *ignore* >>> the settings already today. Maybe word this >>> >>> "This patch enables the client to run IPv6-only on the tun/tap interface, >>> but will not make it ignore a pushed IPv4 config. To achieve that, one >>> can use 'pull-filter ignore "ifconfig "' on the client or 'push-filter' >>> on >>> the server". >>> >>> (if we want to go into this here at all) >> >> >> I don't think this belongs here and such advice could include other >> details like what >> to do with routes, redirect gateway etc. Better add it to the howto. >> > > Agreed to both comments. I'll trim the commit and make it more objective. > >> A more serious thing: >> >> - On windows we require that ifconfig is required with --dev tun. This >> has to change. Could be tricky as TAP_WIN_IOCTL_CONFIG_TUN requires a >> v4 address. > > Is 0.0.0.0 a valid address for this ioctl?
I do not know the tapdriver code enough to answer that.. -- will take a look. > Or does it need to be meaningful? > I think this could be tested by applying only this patch and ignoring > the pushed 'ifconfig ' directive (as explained in the commit). I haven't tested it, but pretty sure that'll just fail with "--dev tun also requires ifconfig" or some such message as can be seen from open_tun() code in tun.c -- it requires did_ifconfig_setup == true which won't get set in init_tun if there are no ifconfig parameters. How to work around that depends on what the tap driver expects in the v4 address. Ideally, we should patch the driver to work without a V4 address... Selva ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
