First, apologies to all those using PINE and similar. Outlook doesn't know what linebreaks or columns are, so I'm stuck compensating with Notepad++. :/
>From: Samuli Seppänen <sam...@openvpn.net> >Sent: 04/29/2018 5:27 AM > >Hi and welcome! Thank you! >> Appveyor will need to be updated to handle the environment and output >> changes; >> I'm happy to explain what's needed, but I have no previous experience with >> the >> service. > >Ilya may be able to help you with that: he has written all our AppVeyor >integrations so far. I'm tweaking my changes so setting up the build environment is a matter of mounting the WDK ISO and tweaking paths.py. Hopefully that helps. >I'm very interested in seeing and testing these changes. I think porting >the buildsystem to a newer SDK would be a good candidate for a PR. >> Along with the SDK changes, the build script needed many changes to add a >> third architecture (ARM64). > >These changes would make another PR. >One final note on PRs/patches: keep them as small and atomic as possible >and they will be easy to review and marge. Just like you did with your >first PR :). I think I see a pattern here, and I like it. :) This PR contains several simple commits: https://github.com/OpenVPN/tap-windows6/pull/52 Would that be better as several PRs (except the two commits that overlap)? With this groundwork laid, here's my PR plan: * change the build system version * move to a newer NDIS version * build for ARM64 * pack ARM64 in the installer Each of these would be a sequence of fairly small, concise commits to aid review. Thanks, Jon ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
