Hello Selva,
On Fri, Jan 12, 2018 at 6:09 PM, Selva Nair <selva.n...@gmail.com> wrote:
> Hi,
>
> I will defer to crypto experts for a proper review, but a quick remark
>
> On Fri, Jan 12, 2018 at 11:48 AM, Emmanuel Deloget <log...@free.fr> wrote:
> > Calling EVP_KEY_id() before EVP_PKEY_get0_*() is unnecessary as
> > the same check is also performed in the later.
> >
> >
> ...
>
> > + RSA *rsa = NULL;
> > + DSA *dsa = NULL;
> > #ifndef OPENSSL_NO_EC
> > - else if ((EVP_PKEY_id(pkey) == EVP_PKEY_EC) &&
> (EVP_PKEY_get0_EC_KEY(pkey) != NULL))
> > + EC *ec = NULL;
>
> That looks wrong: do you mean EC_KEY instead of EC?
>
I definitely mean EC_KEY instead of EC.
My bad. I'm sending a new version of this patch.
>
> > +
> > + if ((ec = EVP_PKEY_get0_EC_KEY(pkey)) != NULL)
>
> Selva
>
BR,
-- Emmanuel Deloget
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
