Hi, v4 looks good and passes my tests and "opinionated" demands.
Thanks, Simon. On Sun, Dec 3, 2017 at 4:16 PM, Simon Rozman <si...@rozman.si> wrote: > > While openvpn.exe can run multiple concurrent processes, openvpnserv.exe > is usually only one single globally unique running process. > > This patch extends openvpnserv.exe to support multiple service instances > in parallel allowing side-by-side OpenVPN installations. > > Alternate instances must be installed as `SERVICE_WIN32_OWN_PROCESS` > (Type 0x10) and must use the newly introduced service command line > parameter: > -instance <name> <id> > <name> can be `automatic` or `interactive`. > > - The service settings will be loaded from `HKLM\Software\OpenVPN<id>` > registry key. > > - The automatic service will use `openvpn<id>_exit_1` exit event. > > - The interactive service will accept requests on > `\\.\pipe\openvpn<id>\service` named pipe, and run IPC with > openvpn.exe on `\\.\pipe\openvpn<id>\service_<pid>`. > > This patch preserves backward compatibility, by defaulting to > `SERVICE_WIN32_SHARE_PROCESS` and `<empty string>` as service ID. > --- Although this is a new feature, the original behaviour is unaffected and the possibility of named instances will help projects like eduVPN use official binary releases. So, I recommend this for 2.4 as well.. Reviewed by: SelvaNair <selva.n...@gmail.com> Acked-by: Selva Nair <selva.n...@gmail.com> ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
