On Thu, Jun 22, 2017 at 6:08 PM, Antonio Quartulli <a...@unstable.cc> wrote: > > On Thu, Jun 22, 2017 at 05:33:44PM +0200, Emmanuel Deloget wrote: > > Hi Antonio, Steffan, > > > > On Thu, Jun 22, 2017 at 3:31 PM, Antonio Quartulli <a...@unstable.cc> wrote: > > > > > Thanks for sending v2 Steffan, > > > > > > On Wed, Jun 21, 2017 at 11:10:43PM +0200, Steffan Karger wrote: > > > > From: Steffan Karger <steffan.kar...@fox-it.com> > > > > > > > > misc.c is a mess of incoherent functions, and is therefore included by > > > > virtually all our source files. That makes testing harder than it > > > > should > > > > be. As a first step of cleaning up misc.c, move adjust_power_of_2() to > > > > integer.h, which is a more suitable place for a function like this. > > > > > > > > This allows us to remove the duplicate implementation from test_argv.c. > > > > > > > > Signed-off-by: Steffan Karger <steffan.kar...@fox-it.com> > > > > > > > > > This change is quite simple and passes basic tests. > > > Thanks also for adding explicit #include statements. > > > > > > Acked-by: Antonio Quartulli <anto...@openvpn.net> > > > > > > > > Since the code is moved, would it be interesting to use a less greedy > > algorithm to do the same thing? I know the function is not used very often, > > so it does not look like it's necessary (it's a suggestion, not a > > commentary on your patch Steffan :)) > > My personal opinion: *never* mix code refactoring with functional changes > (like > what you are suggesting). > > Therefore we'd still need another patch.
Fair enough :) > > > > <snip> > > > > Again, the function is not used extensively, so you can ignore this > > suggestion as it will not speed up openvpn at all :) > > yeah...not sure we need to make some code a bit "obscure" if there is really > no > need. > > Still, I'd suggest to prepare a second patch and propose it over the list. > I'll wait until I see Steffan's patch on master . But as you said, /coda obscura est/ so the commit message will make that very clear. > > Cheers, > -- > Antonio Quartulli BR, -- Emmanuel Deloget ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
