On Tue, Apr 25, 2017 at 12:50:41 +0500, Ilya Shipitsin wrote:
> Inspired by
> https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg13032.html
> build options are taken from regular windows installer builds
>
> Signed-off-by: Ilya Shipitsin <chipits...@gmail.com>
> ---
> v2: moved download/build dependencies into functions, changed cross build
[....]
> +if [ ! -z "${CHOST}" ]; then
> + #
> + # openvpn requires at least mingw-gcc-4.9, which is available at
> xenial repo
> + #
> + echo "deb http://archive.ubuntu.com/ubuntu xenial main universe" |
> sudo tee -a /etc/apt/sources.list.d/xenial.list
> + echo "deb http://archive.ubuntu.com/ubuntu xenial main" | sudo tee -a
> /etc/apt/sources.list.d/xenial.list
I haven't been following all the history of this discussion on the list,
but skimming this most recent version of the patch I noticed that the
above-quoted code adds two separate "deb" lines to xenial.list, both of
which include "main". Presumably that won't actually cause any
problems, but it seemed unlikely to have been intentional....
(I am not familiar with travis, but I take it this code is run in a
context where there's no need to make sure that the "xenial" lines
aren't added repeatedly by multiple runs of this script?)
Nathan
----------------------------------------------------------------------------
Nathan Stratton Treadway - natha...@ontko.com - Mid-Atlantic region
Ray Ontko & Co. - Software consulting services - http://www.ontko.com/
GPG Key: http://www.ontko.com/~nathanst/gpg_key.txt ID: 1023D/ECFB6239
Key fingerprint = 6AD8 485E 20B9 5C71 231C 0C32 15F3 ADCD ECFB 6239
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
