2017-04-25 22:49 GMT+05:00 Steffan Karger <stef...@karger.me>:
> Hi,
>
> On 25-04-17 09:50, Ilya Shipitsin wrote:
> > Inspired by https://www.mail-archive.com/openvpn-devel@lists.
> sourceforge.net/msg13032.html
> > build options are taken from regular windows installer builds
> >
> > Signed-off-by: Ilya Shipitsin <chipits...@gmail.com>
> > ---
> > v2: moved download/build dependencies into functions, changed cross build
> > detection from shell expansion ${CHOST+x} to more recognised -z
> "${CHOST}",
> > which required changing 'set -eux' to 'set -ex'. Added comments to make
> > code readable without looking into commit message.
>
> Thanks, this looks much better now! Just one nit: if we give $CHOST a
> default value, we don't have to remove set -u:
>
defining CHOST when we actually do not need it does not make any sense.
I can keep "set -u" and use shell variable expansion trick
http://stackoverflow.com/questions/3601515/how-to-check-if-a-variable-is-set-in-bash
>
> > --- a/.travis/build-deps.sh
> > +++ b/.travis/build-deps.sh
> > @@ -1,9 +1,58 @@
> > #!/bin/sh
> > -set -eux
> > +set -ex
> >
> > # Set defaults
> > PREFIX="${PREFIX:-${HOME}/opt}"
>
> Just add a CHOST="${CHOST:-}" line here. Keeping -u will help us catch
> future problems (typos in variable names, for example).
>
we already had problems with such complicated definition
https://github.com/OpenVPN/openvpn/commit/368991264d82f038bde30a67910ac6c7681a4ba9#diff-ff51f64442ce689bd8d8466e365dd600R6
those errors are not easy to catch, so I would avoid defining variables in
such way.
I think, we need to remove PREFIX definition as well.
>
> Samuli already verified that this does what it should, so once we can
> get -u back I too agree that this patch is ready to be applied.
>
> Thanks for improving the patch and not giving up :)
>
> -Steffan
>
> ------------------------------------------------------------
> ------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Openvpn-devel mailing list
> Openvpn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
