On 20-03-17 19:28, Gert Doering wrote: > On Mon, Mar 20, 2017 at 07:20:50PM +0100, Steffan Karger wrote: >>> @@ -589,9 +589,7 @@ socket_defined(const socket_descriptor_t sd) >>> /* >>> * Should we include OCC (options consistency check) code? >>> */ >>> -#ifndef ENABLE_SMALL >>> #define ENABLE_OCC >>> -#endif >>> >>> /* >>> * Should we include NTLM proxy functionality >>> >> >> If we unconditionally enable OCC, should we not just rip out #ifdef >> ENABLE_OCC everywhere? > > We certainly could, but someone who still wants "no OCC! smaaall!" > still has the option to turn it off... > > We might revisit that, though - there's "the option checking code", > which indeed brings in quite a bit of code that might be considered > optional, but there is also stuff in sig.c that makes --explicit-exit-notify > depend on ENABLE_OCC, and I'd consider that as something quite > important...
Ok, let's revisit that later. This patch doesn't hurt if we decide to rip out more later, and would be good to get into 2.4.1, so ACK. -Steffan ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
