On 27/01/17 14:56, Илья Шипицин wrote: > > > Basically a patch with commit message consists of three parts: Problem > description, Why and How. The patch diff is the How. These two others > belong to the commit message and often also worthy a comment line or two > in modified files as well - especially if it isn't clear why. > > I would strongly recommend you to read this blog post [1] on writing > commit messages. It is a really good written post on this topic. > > [1] <http://chris.beams.io/posts/git-commit/ > <http://chris.beams.io/posts/git-commit/>> > > > > thank you for the link. > I added more detailed commit description based on that article. > > may I ask you something in turn ? > I cannot read other people thoughts, if there's something wrong with my > patch, there's no other known way, but your reply. > > since, you are keeping silence, I've no idea whether is it wrong or not. > It would be really nice if you will tell "that and that is wrong". I'm > sure, there are sites about git, where it is written.
Fair point, and this is a very common issue in most open source projects. We are not necessarily ignoring you just for the fun of it. But we do look through a lot of patches, and need to prioritise them. For example: Patches which fixes real issues in released OpenVPN versions naturally gets a higher priority than a patch fixing a man page. We who review patches might also misunderstand the importance of them, which is why the commit message is so important. There you give the "selling point" to why we should spend time soonish on doing a proper review and ACK/NAK it. Also, if you have outstanding patches ... it will also help getting some attention if you join the #openvpn-devel channel and ask a bit around. Further, joining the developers meeting can help too; anyone can even add items to the discussion list for those meetings. And lastly, which you did, you asked if your patch could get some attention. So ... don't feel bad that your patches have not been processed yet. This week I managed to get some time to look at a pile of patches from Christian Hesse - he sent most of them before end of December. The reason they got my attention is that it covered my area of interest and expertise, covered issues I have identified myself and we have discussed them on the IRC channel before Christmas last year. So there was a good understanding why we needed those patches. Also, you'll even find patches from me which is lingering on the ML which have also not gained much review yet. So this happens to anyone. In regard to "what is wrong" ... that is truly hard to give some good pointers here. But I try as much as I can to point people into the right direction. On the other side, we do expect people to also do some research and gain more knowledge when we provide some pointers. We don't like to do spoon feeding ;-) And a git trick, which you can instantly benefit from ... when doing git commit ... add the -s argument ;-) -- kind regards, David Sommerseth OpenVPN Technologies, Inc
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
