On 10/01/17 09:04, Ilya Shipitsin wrote: > * moving LD_LIBRARY_PATH as far as possible (otherwise "wget" picks it, which > is not desirable) > * split LD_LIBRARY_PATH into LD_LIBRARY_PATH/DYLD_LIBRARY_PATH depending on > operating system > * removed MBEDTLS_VERSION, OPENSSL_VERSION (the last depended on nonexistent > OPENSSL_VERION variable) > * removed "apt: true" from caching, it never worked actually
Sorry about this lingering ... To the changes itself, I don't have any real possibility to evaluate these changes. From the subject and commit message, I do not understand *why* this is needed. You just describe what I can see in the patch itself. Having an improved commit message actually describing *why* these changes are needed - that helps motivating us to apply it. We don't like to apply things "just because it fixes things". What is this "it" and why is /this/ the right way to do it? Basically a patch with commit message consists of three parts: Problem description, Why and How. The patch diff is the How. These two others belong to the commit message and often also worthy a comment line or two in modified files as well - especially if it isn't clear why. I would strongly recommend you to read this blog post [1] on writing commit messages. It is a really good written post on this topic. [1] <http://chris.beams.io/posts/git-commit/> > this patch should be applied after > https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg13843.html That approach got rejected and we went for this [2] approach instead, will that change anything in regards to the changes in this patch? [2] <https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg13911.html> -- kind regards, David Sommerseth OpenVPN Technologies, Inc
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
