On Tue, Jul 5, 2016 at 4:45 AM, Samuli Seppänen <sam...@openvpn.net> wrote:
> Il 05/07/2016 10:02, Samuli Seppänen ha scritto: > >> Hi, >> >> Hi, >>> >>> On Mon, Jul 4, 2016 at 7:33 AM, Samuli Seppänen <sam...@openvpn.net >>> <mailto:sam...@openvpn.net>> wrote: >>> >>> Here is an installer that includes all the necessary bits to make >>> openvpnserv2/interactive service things work nicely: >>> >>> < >>> http://build.openvpn.net/downloads/snapshots/openvpn-install-2.3_git-I905-x86_64.exe >>> > >>> >>> >>> Tested this installer on windows 7. Works as expected with two minor >>> issues: >>> >>> (i) If service installation checkbox is unselected, interactive service >>> remain selected and obviously fails in the end as no service binaries >>> get installed >>> >> >> Ah yes, I see what you mean. I'll create a dependency between these two >> selections. >> >> (ii) If GUI is running, the installer offers to stop it but in that case >>> it also offers to restart it at the end of installation. That's not good >>> as it gets started as admin (as installer runs as admin) which is not >>> ideal -- at least not what I wanted. I would say just do not offer to >>> start the GUI at all even if it was stopped by the installer -- let the >>> user restart it after installation. >>> >> >> Agreed. >> >> > Hi, > > Fixed the issues you identified: > > <https://github.com/OpenVPN/openvpn-build/pull/23> > < > http://build.openvpn.net/downloads/snapshots/openvpn-install-2.3_git-I907-x86_64.exe > > > > Based on brief testing everything now seems to work correctly. If the user > deselects SecService, then SecInteractiveService is deselected > automatically. > > Right now, when SecService is not selected, clicking on the > SecInteractiveService checkbox does not do anything. This would be nice to > fix, but it is also in line with what we have now. Plus fixing it might not > be as trivial as adding yet another ${If} to the .onSelChange function. The changes look good. One unrelated thing is that that the README file (INSTALL-win32.txt?) shown at the end of the installation is somewhat outdated -- it had comments about the need to start as admin on vista+ etc.. Selva
