Hi,

On Thu, Feb 25, 2016 at 10:24:50PM -0500, Selva Nair wrote:
> - Move the core of win_wfp_block_dns() to a new function
> - Remove globals and make it independent of the rest of the code

Trying to compile this on mingw 32bit, block_dns.c blows up for me
unless I add two more header files to get definitions for ADDRESS_FAMILY
and SOCKADDR_INET (which are referenced by iphlpapi.c)

--- a/src/openvpn/block_dns.c
+++ b/src/openvpn/block_dns.c
@@ -29,6 +29,8 @@
 #include <fwpmu.h>
 #include <initguid.h>
 #include <fwpmtypes.h>
+#include <winsock2.h>
+#include <ws2ipdef.h>
 #include <iphlpapi.h>
 #include "block_dns.h"

... with these changes, both openvpn.exe and openvpnserv.exe compile 
and link nicely.

MS documentation says one should include <winsock2.h>, but that is not
sufficient for me.

So, question 1: is this a mingw issue, or just a 32bit windows requirement
and you only tested on 64bit?

question 2: shall I just add these two header files and take note in
the ACK-and-merge e-mail, or do you want to re-send a v3?

gert
-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             g...@greenie.muc.de
fax: +49-89-35655025                        g...@net.informatik.tu-muenchen.de

Attachment: signature.asc
Description: PGP signature

Reply via email to