I don't think these warnings are all that useful. People who don't have the common sense to read the man-page are probably in trouble anyways. I'd say revert the patch.
Samuli > Hi, > > This is just a minor issue which has been annoying me a little bit. > I've attached a patch which ensures that the --tls-remote semantic > warning is only printed once. > > However, I wonder how useful that warning really is these days. Do > we really need that warning? The warning comes from this commit [1]: > > commit c04bc0223c9b17f203555b933cbeedbf3b343c0e > Author: james <james@e7ae566f-a301-0410-adde-c780ea21d3b5> > Date: Sun Jul 27 18:20:52 2008 +0000 > > Added additional warnings for: > > * --tls-remote -- some people misunderstand the semantics > > * --script-security -- warn if script-security will allow user-defined > scripts to be called, and also warn separately if passwords may be > passed to scripts via the environment > > It's from 2008. I see that in some cases this warning is needed, but I > also think people need to read the man pages when things doesn't work as > expected. Not that we need to hand-hold people the whole way through. > > If we find that all of these warnings are not that useful any more, I'd > rather suggest that we revert the commit above. Otherwise we can also > consider to just remove the --tls-remote warning completely. > > Any thoughts? > > > [1] > <http://openvpn.git.sourceforge.net/git/gitweb.cgi?p=openvpn/openvpn-testing.git;a=commitdiff; > h=c04bc0223c9b17f203555b933cbeedbf3b343c0e> > >
