On 16/01/13 23:11, Mike Tancsa wrote:
> Hi,
>       I have been following the steps to build OpenVPN from the sources and
> was scratching my head as to why the prebuilt binary would work, but my
> build from the sources would bork on --show-pkcs11-ids ?!?!   Searching
> through the mailling list archives shows the patch below, which fixes my
> problem.  It seems that this patch is not in the generic sources?
> 
> I was following the directions at
> https://community.openvpn.net/openvpn/wiki/BuildingUsingGenericBuildsystem#Checkingoutopenvpn-buildrepository
> 
> My question is, why would I not get the correct sources with the fix
> below using the generic build ?  Is there a different / better way to do
> it that whats outlined in the above url ?
> 
> Thanks!

The patch you point at should be in the git repo (applied Nov 22).  It's
commit 5fd3e56430678bee3e6e3a3cf8dfd6db7e105676 in master and commit
fd02ae905df21e1119fb63521e7ff773d6f812dc in beta/2.3.

<http://thread.gmane.org/gmane.network.openvpn.devel/7129/focus=7136>

   $ git tag --contains fd02ae905df21e1119fb63521e7ff773d6f812dc
   v2.3.0
   v2.3_rc2


However, it seems that the generic build tool needs some more tweaking
to grab the packages correctly from github - they changed the download
URLs.  Might be more issues there as well.

Samuli, can you check this?

How I compile OpenVPN is basically directly from the git tree, with
these steps:

  $ autoreconf -vi
  ....
  $ ./configure
  ...
  $ make

And the binary is available in src/openvpn/.  You need pkcs11-helper,
lzo2 and OpenSSL or PolarSSL libraries and development headers
pre-installed though.

But this is probably mostly handy unless you need to do Windows
cross-builds.


--
kind regards,

David Sommerseth



>       ---Mike
> 
> On 11/14/2012 4:03 AM, Adriaan de Jong wrote:
>> [PATCH] Fix --show-pkcs11-ids (Bug #239)
>>
>> Broken by 75b49e406430299b187964744f82e50a9035a0d3.
>>
>> Signed-off-by: Joachim Schipper <joachim.schip...@fox-it.com>
>> ---
>>  src/openvpn/pkcs11.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/openvpn/pkcs11.c b/src/openvpn/pkcs11.c index 
>> 645f1f4..3a15ef6 100644
>> --- a/src/openvpn/pkcs11.c
>> +++ b/src/openvpn/pkcs11.c
>> @@ -887,7 +887,7 @@ show_pkcs11_ids (
>>                    (dn = pkcs11_certificate_dn (
>>                              certificate,
>>                              &gc
>> -                  ))
>> +                  )) == NULL
>>              ) {
>>                      goto cleanup1;
>>              }
>> --
>> 1.7.9.5
>>
>>

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to