Hi,

On Tue, Mar 08, 2011 at 06:52:52PM -0300, Federico Heinz wrote:
> Accept "local if:<ifname>" option.

I can understand why this feature is desirable - there are a couple of
problems with the implementation, though.  

 - From a code modularity point of view, socket stuff should not go 
   to options.c, but to socket.c

 - your code is likely to work on Linux and *BSD, but will it work
   "as is" on Solaris and Windows?  I don't expect it to, so additional 
   #ifdef's are needed --> and that's why it should go to one of the more 
   system-dependent (and already #ifdef-filled) source files


In general, I wonder why binding to the interface is really needed - what
happens if you don't specify "local" at all?  It should pick the proper
source address automatically.

gert


-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             g...@greenie.muc.de
fax: +49-89-35655025                        g...@net.informatik.tu-muenchen.de

Attachment: pgpjJrOl4zbKA.pgp
Description: PGP signature

Reply via email to